<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112463/">http://git.reviewboard.kde.org/r/112463/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If there are further objections/feedback, please share them. If there still is nothing by next friday (13th dec.) then i will go ahead and push.</pre>
<br />
<p>- Mark Gaiser</p>
<br />
<p>On December 5th, 2013, 11:44 p.m. UTC, Mark Gaiser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and KDE Frameworks.</div>
<div>By Mark Gaiser.</div>
<p style="color: grey;"><i>Updated Dec. 5, 2013, 11:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly.
Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use samba 3.x
Once i know that this is actually working then i will comment some qDebug lines.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/CMakeLists.txt <span style="color: grey">(fc594e4)</span></li>
<li>kioslave/smb/CMakeLists.txt <span style="color: grey">(a3a2265)</span></li>
<li>kioslave/smb/kio_smb.h <span style="color: grey">(c2229ab)</span></li>
<li>kioslave/smb/kio_smb.cpp <span style="color: grey">(2c2523a)</span></li>
<li>kioslave/smb/kio_smb_auth.cpp <span style="color: grey">(4d236b4)</span></li>
<li>kioslave/smb/kio_smb_browse.cpp <span style="color: grey">(5253be9)</span></li>
<li>kioslave/smb/kio_smb_dir.cpp <span style="color: grey">(ba80c86)</span></li>
<li>kioslave/smb/kio_smb_file.cpp <span style="color: grey">(206526a)</span></li>
<li>kioslave/smb/kio_smb_internal.h <span style="color: grey">(4b946c1)</span></li>
<li>kioslave/smb/kio_smb_internal.cpp <span style="color: grey">(e943844)</span></li>
<li>kioslave/smb/kio_smb_mount.cpp <span style="color: grey">(a5a7e8e)</span></li>
<li>kioslave/smb/kio_smb_win.h <span style="color: grey">(f1dcb6f)</span></li>
<li>kioslave/smb/kio_smb_win.cpp <span style="color: grey">(14dd797)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112463/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>