<div dir="ltr">Bump.<div><br></div><div>Can anyone look at this?</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Dec 1, 2013 at 10:32 PM, Mark Gaiser <span dir="ltr"><<a href="mailto:markg85@gmail.com" target="_blank">markg85@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112463/" target="_blank">http://git.reviewboard.kde.org/r/112463/</a>
</td>
</tr>
</tbody></table>
<br>
</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image:url('');background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td><div class="im">
<div>Review request for KDE Runtime and KDE Frameworks.</div>
<div>By Mark Gaiser.</div>
</div><p style="color:grey"><i>Updated Dec. 1, 2013, 9:32 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Updated diff since Dawit is done with his patches.
I tried to be as thorough as possible with this porting. You won't see any new notices or warning coming from this patch. I at least didn't saw any in my test compiles.
As for testing this. I did manage to test it and got file listings back. So that makes me think that it's ported properly and working. But i have to say that testing this is very tricky! The applications that one would normally use to verify if everything is OK (aka, dolphin) is not possible because dolphin isn't ported. Testing it in my new app "Accretion" is possible, but not reliable since that is in heavy development. If something doesn't show up there it doesn't mean the slave is broken :)
So this patch is partly based on guess work. It looks like it's working fine.
On the other hand, if it isn't i'm likely the one finding it out anyway since i'm digging around a lot in this area lately.</pre>
</td>
</tr>
</tbody></table>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
kde-runtime
</div><div class="im">
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly.
Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: <a href="https://git.reviewboard.kde.org/r/112448/" target="_blank">https://git.reviewboard.kde.org/r/112448/</a> you're probably OK if you still use samba 3.x
Once i know that this is actually working then i will comment some qDebug lines.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken.</pre>
</td>
</tr>
</tbody></table>
</div><h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs (updated)</h1>
<ul style="margin-left:3em;padding-left:0">
<li>kioslave/CMakeLists.txt <span style="color:grey">(fc594e4)</span></li>
<li>kioslave/smb/CMakeLists.txt <span style="color:grey">(a3a2265)</span></li>
<li>kioslave/smb/kio_smb.h <span style="color:grey">(c2229ab)</span></li>
<li>kioslave/smb/kio_smb.cpp <span style="color:grey">(2c2523a)</span></li>
<li>kioslave/smb/kio_smb_auth.cpp <span style="color:grey">(4d236b4)</span></li>
<li>kioslave/smb/kio_smb_browse.cpp <span style="color:grey">(5253be9)</span></li>
<li>kioslave/smb/kio_smb_dir.cpp <span style="color:grey">(ba80c86)</span></li>
<li>kioslave/smb/kio_smb_file.cpp <span style="color:grey">(206526a)</span></li>
<li>kioslave/smb/kio_smb_internal.h <span style="color:grey">(4b946c1)</span></li>
<li>kioslave/smb/kio_smb_internal.cpp <span style="color:grey">(e943844)</span></li>
<li>kioslave/smb/kio_smb_mount.cpp <span style="color:grey">(a5a7e8e)</span></li>
<li>kioslave/smb/kio_smb_win.h <span style="color:grey">(f1dcb6f)</span></li>
<li>kioslave/smb/kio_smb_win.cpp <span style="color:grey">(14dd797)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112463/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br></div>