<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114214/">http://git.reviewboard.kde.org/r/114214/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and kdewin.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2013, 9 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is one global static for a QDesktopWidget in the code. We do not really need that, given that QApplication returns a static instance already.
This also fixes a bug I have in when closing yakuake:
Application: Yakuake (yakuake), signal: EXCEPTION_ACCESS_VIOLATION
QtGuid4.dll!QScopedPointer<QObjectData,QScopedPointerDeleter<QObjectData> >::data() [q:\qt-4.8.2\src\corelib\tools\qscopedpointer.h @ 135] at 0x54e6566a
QtGuid4.dll!qGetPtrHelper<QScopedPointer<QObjectData,QScopedPointerDeleter<QObjectData> > >() [q:\qt-4.8.2\src\corelib\global\qglobal.h @ 2455] at 0x54e53d5b
QtGuid4.dll!QApplication::d_func() [q:\qt-4.8.2\src\gui\kernel\qapplication.h @ 390] at 0x54e5e213
QtGuid4.dll!QWidget::~QWidget() [q:\qt-4.8.2\src\gui\kernel\qwidget.cpp @ 1634] at 0x54eeaa5b
QtGuid4.dll!QDesktopWidget::~QDesktopWidget() [q:\qt-4.8.2\src\gui\kernel\qdesktopwidget_win.cpp @ 253] at 0x54f41002
kdeui.dll!QDesktopWidget::`scalar deleting destructor'() [[unknown] @ -1] at 0x5435921a
kdeui.dll!_k_s_deskWidget__LINE__::destroy() [r:\build\kde\kdelibs-20110130\work\kdelibs-4.10.2\kdeui\windowmanagement\kwindowsystem_win.cpp @ 60] at 0x543591bb
kdeui.dll!KCleanUpGlobalStatic::~KCleanUpGlobalStatic() [r:\build\kde\kdelibs-20110130\work\kdelibs-4.10.2\kdecore\kernel\kglobal.h @ 62] at 0x53f68498
kdeui.dll!`_k_s_deskWidget__LINE__::operator->'::`13'::`dynamic atexit destructor for 'cleanUpObject''() [[unknown] @ -1] at 0x543f76ad
kdeui.dll!_CRT_INIT() [f:\dd\vctools\crt_bld\self_x86\crt\src\crtdll.c @ 415] at 0x54372424
kdeui.dll!__DllMainCRTStartup() [f:\dd\vctools\crt_bld\self_x86\crt\src\crtdll.c @ 526] at 0x54372630
...
I don't think it breaks anything.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On Windows msvc2010 ;-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/windowmanagement/kwindowsystem_win.cpp <span style="color: grey">(e5b3a23)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114214/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>