<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112463/">http://git.reviewboard.kde.org/r/112463/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 26th, 2013, 5:12 p.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's been stalled for almost three months now, any chance to see progress or should it be discarded?</pre>
</blockquote>
<p>On November 26th, 2013, 7:54 p.m. UTC, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, it should most certainly not be disgarded. It was even working when i posted this post up for review.
Dawit, how are you doing in the SMB improvements that you had in mind?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I forgot to inform you. I have already merged my changes into 4.12 and master branches.</pre>
<br />
<p>- Dawit</p>
<br />
<p>On September 2nd, 2013, 7:16 p.m. UTC, Mark Gaiser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and KDE Frameworks.</div>
<div>By Mark Gaiser.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2013, 7:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly.
Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use samba 3.x
Once i know that this is actually working then i will comment some qDebug lines.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/CMakeLists.txt <span style="color: grey">(ff66ab6)</span></li>
<li>kioslave/smb/CMakeLists.txt <span style="color: grey">(a3a2265)</span></li>
<li>kioslave/smb/kio_smb.h <span style="color: grey">(55efb44)</span></li>
<li>kioslave/smb/kio_smb.cpp <span style="color: grey">(2c2523a)</span></li>
<li>kioslave/smb/kio_smb_auth.cpp <span style="color: grey">(4d236b4)</span></li>
<li>kioslave/smb/kio_smb_browse.cpp <span style="color: grey">(fec6449)</span></li>
<li>kioslave/smb/kio_smb_config.cpp <span style="color: grey">(81ce29c)</span></li>
<li>kioslave/smb/kio_smb_dir.cpp <span style="color: grey">(5573266)</span></li>
<li>kioslave/smb/kio_smb_file.cpp <span style="color: grey">(827a519)</span></li>
<li>kioslave/smb/kio_smb_internal.h <span style="color: grey">(b895b81)</span></li>
<li>kioslave/smb/kio_smb_internal.cpp <span style="color: grey">(3c35583)</span></li>
<li>kioslave/smb/kio_smb_mount.cpp <span style="color: grey">(a5a7e8e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112463/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>