<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113993/">http://git.reviewboard.kde.org/r/113993/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By Alex Merry.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the nowplaying dataengine
This has been superceded by the mpris2 dataengine.
(And good riddance)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CMake still runs successfully.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/CMakeLists.txt <span style="color: grey">(ee010a9)</span></li>
<li>plasma/generic/dataengines/nowplaying/CMakeLists.txt <span style="color: grey">(ebb9e8e)</span></li>
<li>plasma/generic/dataengines/nowplaying/Messages.sh <span style="color: grey">(eaac8ef)</span></li>
<li>plasma/generic/dataengines/nowplaying/TODO <span style="color: grey">(557902f)</span></li>
<li>plasma/generic/dataengines/nowplaying/config-nowplaying.cmake <span style="color: grey">(c596066)</span></li>
<li>plasma/generic/dataengines/nowplaying/nowplaying.operations <span style="color: grey">(4a5587d)</span></li>
<li>plasma/generic/dataengines/nowplaying/nowplayingengine.h <span style="color: grey">(780233c)</span></li>
<li>plasma/generic/dataengines/nowplaying/nowplayingengine.cpp <span style="color: grey">(f88d739)</span></li>
<li>plasma/generic/dataengines/nowplaying/plasma-dataengine-nowplaying.desktop <span style="color: grey">(7717082)</span></li>
<li>plasma/generic/dataengines/nowplaying/playeractionjob.h <span style="color: grey">(0cfbf1b)</span></li>
<li>plasma/generic/dataengines/nowplaying/playeractionjob.cpp <span style="color: grey">(6943c25)</span></li>
<li>plasma/generic/dataengines/nowplaying/playercontainer.h <span style="color: grey">(06360e0)</span></li>
<li>plasma/generic/dataengines/nowplaying/playercontainer.cpp <span style="color: grey">(79db747)</span></li>
<li>plasma/generic/dataengines/nowplaying/playercontrol.h <span style="color: grey">(760498d)</span></li>
<li>plasma/generic/dataengines/nowplaying/playercontrol.cpp <span style="color: grey">(7480af1)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/dbuswatcher.h <span style="color: grey">(38522ef)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/dbuswatcher.cpp <span style="color: grey">(3e7396a)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/juk.h <span style="color: grey">(5f44618)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/juk.cpp <span style="color: grey">(ad3deb6)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/juk_p.h <span style="color: grey">(d8f672c)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/mpris/mpris.h <span style="color: grey">(cb8cf83)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/mpris/mpris.cpp <span style="color: grey">(69c3c3c)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/mpris/mpris_p.h <span style="color: grey">(d8c3121)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/mpris/mprisdbustypes.h <span style="color: grey">(325f3e4)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/mpris/mprisdbustypes.cpp <span style="color: grey">(2d42a50)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/mpris/org.freedesktop.MediaPlayer.player.xml <span style="color: grey">(302c383)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/mpris/org.freedesktop.MediaPlayer.root.xml <span style="color: grey">(aa93e4b)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/mpris/org.freedesktop.MediaPlayer.tracklist.xml <span style="color: grey">(e8cb127)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/mpris2/mpris2.h <span style="color: grey">(0ab3650)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/mpris2/mpris2.cpp <span style="color: grey">(fbc0689)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/mpris2/mpris2_p.h <span style="color: grey">(04a3a76)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/org.kde.juk.player.xml <span style="color: grey">(bb6e18d)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/player.h <span style="color: grey">(9c2e0fc)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/player.cpp <span style="color: grey">(b0f2680)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/playerfactory.h <span style="color: grey">(27371f3)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/playerfactory.cpp <span style="color: grey">(53c1724)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/pollingwatcher.h <span style="color: grey">(34446da)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/pollingwatcher.cpp <span style="color: grey">(cf6bd99)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/xmms.h <span style="color: grey">(8e58c73)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/xmms.cpp <span style="color: grey">(da3e9db)</span></li>
<li>plasma/generic/dataengines/nowplaying/playerinterface/xmms_p.h <span style="color: grey">(10a6e51)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113993/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>