<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113885/">http://git.reviewboard.kde.org/r/113885/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 20th, 2013, 12:21 p.m. UTC, <b>Fredrik Höglund</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113885/diff/1/?file=214306#file214306line143" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kwindowsystem/src/kwindoweffects.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace KWindowEffects</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">136</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KWINDOWSYSTEM_EXPORT</span> <span class="kt">void</span> <span class="nf">enableBlurBehind</span><span class="p">(</span><span class="n">WId</span> <span class="n">window</span><span class="p">,</span> <span class="kt">bool</span> <span class="n">enable</span> <span class="o">=</span> <span class="nb">true</span><span class="p">,</span> <span class="k">const</span> <span class="n">QRegion</span> <span class="o">&</span><span class="n">region</span> <span class="o">=</span> <span class="n">QRegion</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">143</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KWINDOWSYSTEM_EXPORT</span> <span class="kt">void</span> <span class="nf">enableBlurBehind</span><span class="p">(</span><span class="n">WId</span> <span class="n">window</span><span class="p">,</span> <span class="kt">bool</span> <span class="n">enable</span> <span class="o">=</span> <span class="nb">true</span><span class="p">,</span> <span class="k">const</span> <span class="n">QRegion</span> <span class="o">&</span><span class="n">region</span> <span class="o">=</span> <span class="n">QRegion</span><span class="p">()<span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">BlurBehindEffect</span></span><span class="hl"> </span><span class="n"><span class="hl">blurBehindEffect</span></span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="n"><span class="hl">NormalBlur</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">An unfortunate side effect of this is that this API becomes incompatible with the equivalent API on Windows.
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">so on windows the parameter would have to be a no-op, that yeah, is not beautiful</pre>
<br />
<p>- Marco</p>
<br />
<p>On November 15th, 2013, 2:54 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and kwin.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2013, 2:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To enhance readability, not only blur the background, but if the right x property is provided, either make the color of the pixels lighter or darker, decreasing the contrast a lot.
This is different from just making the window more opaque, since it doesn't cover the information about color, but just information about contrast, making the end result better looking.
This is the kdelibs facing part of http://git.reviewboard.kde.org/r/113884/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kwindowsystem/src/kwindoweffects.h <span style="color: grey">(78195ac)</span></li>
<li>tier1/kwindowsystem/src/kwindoweffects_dummy.cpp <span style="color: grey">(ce3b9bf)</span></li>
<li>tier1/kwindowsystem/src/kwindoweffects_x11.cpp <span style="color: grey">(9e3fba7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113885/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>