<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113630/">http://git.reviewboard.kde.org/r/113630/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113630/diff/2/?file=209126#file209126line3" style="color: black; font-weight: bold; text-decoration: underline;">ksplash/ksplashqml/themes/Classic/Theme.rc</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">Description</span> <span class="o">=</span> <span class="n">Splash</span> <span class="n">Screen</span> <span class="n">from</span> <span class="n">the</span> <span class="n">good</span> <span class="n">old</span> <span class="n">KDE</span> <span class="m">4</span> <span class="n">series</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDE SC :)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113630/diff/2/?file=209134#file209134line75" style="color: black; font-weight: bold; text-decoration: underline;">ksplash/ksplashqml/themes/Classic/main.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">x:</span> <span class="p">((</span><span class="nx">iconsBackgroundRect</span><span class="p">.</span><span class="nx">width</span> <span class="o">/</span> <span class="mi">10</span><span class="p">)</span> <span class="o">-</span> <span class="nx">iconSize</span> <span class="o">/</span> <span class="mi">2</span><span class="p">)</span> <span class="o">+</span> <span class="mi">8</span> <span class="c1">//8 being inner padding from the background rect, just looks better(tm)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can use a Row or ListView here, and have the layouting done automatically. Same for the other icons.
I'd suggest an ObjectModel, or indeed a Row: http://qt-project.org/doc/qt-5.1/qtqml/qml-qtqml-models2-objectmodel.html
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113630/diff/2/?file=209134#file209134line95" style="color: black; font-weight: bold; text-decoration: underline;">ksplash/ksplashqml/themes/Classic/main.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">95</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">Behavior</span> <span class="nx">on</span> <span class="nx">opacity</span> <span class="p">{</span> <span class="nx">NumberAnimation</span> <span class="p">{</span> <span class="k">duration:</span> <span class="mi">1000</span><span class="p">;</span> <span class="nx">easing</span> <span class="p">{</span> <span class="k">type:</span> <span class="nx">Easing</span><span class="p">.</span><span class="nx">InOutQuad</span> <span class="p">}</span> <span class="p">}</span> <span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Encapsulate the NumberAnimation into its own file. It should be easy to change.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113630/diff/2/?file=209134#file209134line132" style="color: black; font-weight: bold; text-decoration: underline;">ksplash/ksplashqml/themes/Classic/main.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">132</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">width:</span> <span class="mi">125</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks odd?</pre>
</div>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On November 5th, 2013, 10:42 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 5, 2013, 10:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Last thing on my ksplash list is to port the good old KDE4 theme as "Classic" theme done in QML. I'm a QML noob so I'm putting it up for some comments. It works (and looks) just like the original theme. I reconstructed it using the original images.
I'll put it into kde-workspace/ksplash, where it can be further improved, then it can be moved to some Look&Feel package later on.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works just like in KDE4.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksplash/ksplashqml/themes/CMakeLists.txt <span style="color: grey">(c5ab367)</span></li>
<li>ksplash/ksplashqml/themes/Classic/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksplash/ksplashqml/themes/Classic/Preview.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksplash/ksplashqml/themes/Classic/Theme.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksplash/ksplashqml/themes/Classic/images/background.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksplash/ksplashqml/themes/Classic/images/icon1.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksplash/ksplashqml/themes/Classic/images/icon2.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksplash/ksplashqml/themes/Classic/images/icon3.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksplash/ksplashqml/themes/Classic/images/icon4.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksplash/ksplashqml/themes/Classic/images/icon5.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksplash/ksplashqml/themes/Classic/images/rectangle.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksplash/ksplashqml/themes/Classic/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113630/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/04/b7596f8c-2df3-4e62-bcbd-ee0e5ad5afc4__ksplash_classic.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>