<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113413/">http://git.reviewboard.kde.org/r/113413/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 25th, 2013, 7:58 p.m. UTC, <b>Xuetian Weng</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you also post a preview for French ? It should have 4 symbol on one key, I'd like to how that looks.
Seems you didn't parse the led information? (It's ok to leave it there)
Some key name doesn't looks correct (F1 - F12), could you use X11keysym.h to get the key name in X11? Or use XKeysymToString in libX11 maybe.
Some key string position can be improved, for example, the "Space" in second screenshot.</pre>
</blockquote>
<p>On October 26th, 2013, 1:13 p.m. UTC, <b>shivam makkar</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have no idea how to extract key names using X11, andriy rysin has done the work related to mapping (for which I am really grateful to him).
It would be great if I could get some documentation or examples related to this.
I've french the french keyboard layout, it even support more than 4 levels (like in german neo2 layout) it creates a combobox to select which levels you want to display apart from level 1&2. </pre>
</blockquote>
<p>On October 27th, 2013, 2:30 a.m. UTC, <b>Xuetian Weng</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as I stated before, XKeysymToString will do the trick, man it then you can find how to use it. It accepts a X11 keysym and return the key sym name in /usr/include/X11/keysymdef.h
And convert X11 keysym to unicode, you might want take a look at libxkbcommon implementation
http://cgit.freedesktop.org/xorg/lib/libxkbcommon/tree/src/keysym-utf.c
If we don't want libxkbcommon as dependency here, I think you can copy some of the code.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Copying code is never a good idea (unless it's 2 lines of code)</pre>
<br />
<p>- Albert</p>
<br />
<p>On October 26th, 2013, 1:12 p.m. UTC, shivam makkar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime, kde-workspace and Andriy Rysin.</div>
<div>By shivam makkar.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2013, 1:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improved keyboard layout preview
added geometry feature, multi-level keys (>4) and parsed geometry file using Boost c++ libraries and tool tip showing symbol names.
my GSoC-13 project !</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/keyboard/preview/geometry_components.cpp <span style="color: grey">(65c47f0)</span></li>
<li>kcontrol/keyboard/preview/kbpreviewframe.h <span style="color: grey">(7cfefa5)</span></li>
<li>kcontrol/keyboard/preview/kbpreviewframe.cpp <span style="color: grey">(903a4f0)</span></li>
<li>kcontrol/keyboard/preview/keyboardpainter.cpp <span style="color: grey">(a740d44)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113413/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/25/48fead43-1cfc-4cce-9d37-0943b3e780cd__snapshot11.jpg">English layout on default geometry</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/26/19226ef7-53fd-4a43-af48-94731eca2cb5__snapshot13.jpg">french layout default geometry</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/26/cc9cae25-2366-4978-98b0-d83b41eabc09__snapshot14.jpg">Fixed position of the key names</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/26/584a9877-4875-48ce-957e-51b1cc19b76e__snapshot15.jpg">german neo 2 with level 1,2,5,6 instead of 1,2,3,4</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>