<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113447/">http://git.reviewboard.kde.org/r/113447/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is also a pretty bad hack because it will cause all usages of this on files that *should* be merged to exhibit strange behaviour. however, that is not how it is used in libplasma, so having this hack is preferable to having broken config updates.
for KF5, this points to how kconfig needs work -> it should be possible to retrieve the OpenFlags that were used to create it; reparse should *not* cause a sync() just to re-read values from disk, values on disk that have changed should override the values set in the config object and life should continue on as expected. that a *read* action causes a *write* is completely unexpected from an application API POV.</pre>
<br />
<p>- Aaron J. Seigo</p>
<br />
<p>On October 27th, 2013, 12:19 p.m. UTC, Eike Hein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Eike Hein.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2013, 12:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please see https://git.reviewboard.kde.org/r/113443/ for the earlier attempt and Aaron's review, which lead to this new take.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/configloader.cpp <span style="color: grey">(6e97cb9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113447/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>