<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113415/">http://git.reviewboard.kde.org/r/113415/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 24th, 2013, 4:17 p.m. UTC, <b>Fredrik Höglund</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's the cold startup time like for KSplashQML compared to KSplashX?
Let's not forget that the reason KPlash was rewritten to only depend on
X + libjpeg + libpng was so that the startup time would be limited by
the time it takes to load the images for the theme.
</pre>
</blockquote>
<p>On October 24th, 2013, 4:22 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">but that's a long time ago, isn't it? So Moore's Law... Anyway could be interesting to do such comparisons on spinning metal.</pre>
</blockquote>
<p>On October 24th, 2013, 4:24 p.m. UTC, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We haven't done any real benchmarks, but it doesn't seem to be noticeably slower.
It should not slow down the boot - if it does start slower than ksplashx, it speeds up loading the workspace for the same amount by having Qt preloaded.</pre>
</blockquote>
<p>On October 24th, 2013, 4:55 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't the splash screen supposed to cover (also) those loading costs?
If the splashscreen took like 5 seconds to load but then could finish in 500ms, we would simply not require a splash screen in the first place.</pre>
</blockquote>
<p>On October 24th, 2013, 5 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've never done any (useful) startup benchmarks, but I'd be happy to try. Can you suggest some ways to measure cold startup time? Then I'll test both and post my findings.</pre>
</blockquote>
<p>On October 24th, 2013, 5:08 p.m. UTC, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If loading Qt took 5 seconds, loading the rest would take 10 minutes.
As I said "doesn't seem to be noticeably slower".</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">echo 1 > /proc/sys/vm/drop_caches
Clears all filesystem caches, so that everything has to be loaded from disk, that's essentially what you have after a cold boot.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On October 24th, 2013, 2:19 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2013, 2:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ports KSplashQML to Qt5 and strips any XLib stuff. Martin G. suggested to try if it would simply work without XLib/XCB bits at all and it does work in testing mode, I'm unsure if it also works after actual login, but I don't see why it wouldn't.
KSplash was also receiving the stage messages via XAtoms, which I replaced with simple DBus interface. That means that all the parts in the login sequence need to be updated (I'll do it) to emit dbus signal instead of sending X message. I used the same API as the XAtoms were using, but let me know if you think this could be changed. In some future I'd probably also change the stages resolution as it's not too robust and does not help paralelization much. I have a plan in my head but that's for another commit.
I'd also like to remove the old KSplashX and port its default theme to QML and provide together with KSplashQML as "Classic" or "KDE 4" theme.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Theme successfully loads, displays fullscreen (Plasma panels are not covered, not sure why), all stages passes, then it terminates itself.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksplash/ksplashqml/CMakeLists.txt <span style="color: grey">(8cd5305)</span></li>
<li>ksplash/ksplashqml/SplashApp.h <span style="color: grey">(3c55be9)</span></li>
<li>ksplash/ksplashqml/SplashApp.cpp <span style="color: grey">(7c528d0)</span></li>
<li>ksplash/ksplashqml/SplashWindow.h <span style="color: grey">(9680c1e)</span></li>
<li>ksplash/ksplashqml/SplashWindow.cpp <span style="color: grey">(4417643)</span></li>
<li>ksplash/ksplashqml/SystemInfo.h <span style="color: grey">(7a74554)</span></li>
<li>ksplash/ksplashqml/main.cpp <span style="color: grey">(c2722ab9)</span></li>
<li>ksplash/ksplashqml/org.kde.KSplash.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksplash/ksplashqml/themes/Minimalistic/main.qml <span style="color: grey">(e4fb8b8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113415/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>