<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113175/">http://git.reviewboard.kde.org/r/113175/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 8th, 2013, 1:47 p.m. ART, <b>Jonathan Marten</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not totally happy with this change. Yes, the internal viewer is limited in functionality, but it has advantages: (1) it is fast to open and can be closed again with a single keystroke; (2) it remembers its size and can be resized without affecting the default window size of, say, KWrite or whichever external application is used; (3) it can be forced to display an archive component of any type as plain text.
There's nothing wrong with having the facility to open an archive component in its default application (or any other application), but it should be an option. Either a configuration setting (Use internal viewer - Use external application), or a context menu with options View (in the internal viewer), Open (in the default application) or Open With... (any other application).</pre>
</blockquote>
<p>On October 8th, 2013, 1:59 p.m. ART, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guessed some people would not be happy with it, but it was worth a try ;)
How about a context menu action? Or, since the context menu is currently empty, just opening the external viewer on right-click?</pre>
</blockquote>
<p>On October 8th, 2013, 2:55 p.m. ART, <b>Jonathan Marten</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure that changing the function of the right-click would be approved of (but then, I'm not the ark maintainer or authority, just an intensive user of it). Maybe the middle button?
There has been some discussion about adding a context menu to Ark before now - e.g. bug #166203.
</pre>
</blockquote>
<p>On October 8th, 2013, 3:54 p.m. ART, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Honestly, to most people the internal viewer just looks broken, like an incomplete stepchild of the real viewer application.
Can we please at least make the default to open the application, not the crippled viewer?</pre>
</blockquote>
<p>On October 8th, 2013, 4:49 p.m. ART, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I feel like Sebastian does and I have watched people use Ark before which obviously felt the same (i.e. which were confused because the PDF viewer was missing all the buttons). I do see the point of the viewer in some corner cases, but in almost all cases I don't want it.
Maybe we could do this: The side panel is currently quite useless (huge amount of space occupied + little information in there). We could embed the viewer there, and change the action on click to select the file and display it there. That would serve the (I guess?) common use case, which is looking through several images and deciding which one you want to extract even better than the current solution. Then there could be a button below the viewer widget to open the file in the actual application.
I'm not sure this is a good idea, what do you think?</pre>
</blockquote>
<p>On October 8th, 2013, 5:35 p.m. ART, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I see the problem with that approach -- it requires extracting files on selecting them, which is of course not optimal.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To add my 2 cents, these are the things I find most annoying:
- XML files are shown in the internal viewer using the KHTML KPart, which is pretty useless unless the file happens to be XHTML. For many XML files I get an empty window because there are no text nodes (all data in attributes).
- Diff files appear using a KPart (I don't remember if it's Kompare or KDiff3) that only shows the diff for the first file by default. Usually there are controls to go to the next file, but as mentioned by Sven, Ark shows no controls. Keyboard shortcuts don't work either.
- Some other formats show a "can't be opened in the internal viewer" error.</pre>
<br />
<p>- Nicolás</p>
<br />
<p>On October 8th, 2013, 12:23 p.m. ART, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2013, 12:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes ark always use an external viewer application instead of using the clunky internal preview thing. The internal viewer would just embed a plain kpart into a window, but without providing any of the XMLGUI or whatever from that part. Thus, when you for example clicked a PDF, you couldn't print it. The advantages of the internal viewer are imo overall quite questionable, and are far outweighted by its disadvantages.
Plus, it removes code ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clicking files opens them in the default application, as it should.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/CMakeLists.txt <span style="color: grey">(9e384438b60322f1d51d31e40c556b2912970ceb)</span></li>
<li>part/arkviewer.h <span style="color: grey">(bb41472eaec985e2e1b3d9c2f7c257c949316bf4)</span></li>
<li>part/arkviewer.cpp <span style="color: grey">(053cd1c0502d3bb88895dc8d3653eaea9e6c3c83)</span></li>
<li>part/part.cpp <span style="color: grey">(b4ebcd27c462d2b8037b5ea40c56969eda71bdcb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113175/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>