<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112848/">http://git.reviewboard.kde.org/r/112848/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 5th, 2013, 5:17 a.m. AMT, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One thing I just noticed -- KButtonGroup is deprecated in KF5, in favour of QGroupBox + QButtonGroup.
So while this is certainly good to go in, you might want to use QGroupBox+QButtonGroup in your code instead...
Shall I commit it for you? AFAICS you have no git account?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi David,
Could you commit it for me ? I don't have git r/w privileges yet. I'm using a repo with anonymous read-only access.
I will follow your advice about QGroupBox + QButtonGroup ;)</pre>
<br />
<p>- Bruno</p>
<br />
<p>On October 10th, 2013, 6:36 p.m. AMT, Bruno Farias wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bruno Farias.</div>
<p style="color: grey;"><i>Updated Oct. 10, 2013, 6:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Adding new test for kbuttongroup
- Fixing kbuttongroup.cpp identation</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All tests of KButtonGroupTest were passed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/tests/kbuttongrouptest.h <span style="color: grey">(cd9130a9b0840160bdce5a1841735e2050d10a7d)</span></li>
<li>kdeui/tests/kbuttongrouptest.cpp <span style="color: grey">(d5f9f88b839d4be88cac81c1e7d0444422dd17ea)</span></li>
<li>kdeui/widgets/kbuttongroup.h <span style="color: grey">(de813ea95dca1247698537a966abe474fa9650cf)</span></li>
<li>kdeui/widgets/kbuttongroup.cpp <span style="color: grey">(4057cc023107cd76cc34590f4b1dd91e01717d3d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112848/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>