<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113162/">http://git.reviewboard.kde.org/r/113162/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 9th, 2013, 11:24 a.m. UTC, <b>Jan Kundrát</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can even make it a `const char * const` to communicate that the actual pointer itself is const, too.
That said, in this particular case I would just use a hardcoded "HOME" in both getenv and setenv for simplicity, but I'm not a kdelibs developer.</pre>
</blockquote>
<p>On October 9th, 2013, 12:18 p.m. UTC, <b>Jiří Pinkava</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">insert string "HOME" directly is not good idea (in general) because optimalizator is forced (by C/C++ standard) to allocate two strings in memory (even if they are identical).
the mous used construction is
const char home[] = "HOME";</pre>
</blockquote>
<p>On October 9th, 2013, 1:18 p.m. UTC, <b>Jan Kundrát</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would appreciate a citation here. http://stackoverflow.com/questions/690176/c-c-optimization-of-pointers-to-string-constants disagrees with what you're claiming, and contains an example to make a point.</pre>
</blockquote>
<p>On October 9th, 2013, 1:44 p.m. UTC, <b>Jiří Pinkava</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thansk for correction.
I would recomand still use previous form, because it (in generel) does not allow typo when the same text should used.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In general true, but in particular i'd say that would make the code largely more readable.
Attach Dario or Nicola explicitly: their code, their choice - this is religion ;-)</pre>
<br />
<p>- Thomas</p>
<br />
<p>On October 7th, 2013, 7:40 p.m. UTC, Jiří Pinkava wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jiří Pinkava.</div>
<p style="color: grey;"><i>Updated Oct. 7, 2013, 7:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">oneline fix: char -> const char</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/auth/kauthhelpersupport.cpp <span style="color: grey">(f99b64d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113162/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>