<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113129/">http://git.reviewboard.kde.org/r/113129/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the fix.</pre>
<br />
<p>- Dawit Alemayehu</p>
<br />
<p>On October 6th, 2013, 12:36 p.m. UTC, Andrea Iacovitti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and Dawit Alemayehu.</div>
<div>By Andrea Iacovitti.</div>
<p style="color: grey;"><i>Updated Oct. 6, 2013, 12:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304707">304707</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Use the correct variable, instead of the entire QStringList, to fill in lineedit's text in autoDetectSystemProxy.
- When saving for "System proxy configuration", in KProxyDialog::save(), be sure to write the name of environment variables and not their values in the configuration file.
- Added missing signal connection for mUi.systemProxyRadioButton.
- Connect slotChanged() to textEdited() signal (instead of textChanged()) for systemProxy's lineedits, this avoid to emit changed() when "Show the value of the envirnment variables" checkbox is clicked.
NOTE:
Currently (and from kde3 time) the proxy configuration keys in kioslaverc: httpProxy,httpsProxy,ftpProxy,socksProxy,NoProxyFor, are used with a double semantic. They hold the proxy address in case of "Manual Proxy Configuration" or the name of environment variables to use in case of "System Proxy Configuration". (See getSystemProxyFor() in kprotocolmanager.cpp)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/settings/kio/kproxydlg.cpp <span style="color: grey">(7c777d3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113129/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>