<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112328/">http://git.reviewboard.kde.org/r/112328/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 4th, 2013, 8:25 p.m. CEST, <b>Eugene Shalygin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm thankfull to all of you for lloking into this! Now I do not know what to do with these changes. If there will bee no new kdelibs 4.x releases, how these changes can be released? Will it happen only with Frameworks 5?</pre>
</blockquote>
<p>On September 5th, 2013, 10:31 a.m. CEST, <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To my knowledge, kde-workspace is the only part of the KDE SC that will not have a 4.12 release.
About the "proper way" that Martin referred to: there was a discussion on the frameworks mailing list about KGlobalSettings some time ago. It starts here:
http://comments.gmane.org/gmane.comp.kde.devel.frameworks/3976
and ends here:
http://mail.kde.org/pipermail/kde-frameworks-devel/2013-August/003966.html
(I could not find a good way to link to a mail thread that spans multiple months, sorry).
I'm not an expert for these things though, and I'm not quite sure if I understand what the "proper way" is and if it can already be applied to 4.12. If it's not possible to add that functionality to kdelibs 4.12, then we could add a Dolphin-specific setting for the case sensitivity for the rest of the 4.x era. In that case, the feature would not be available in the file dialog though (even now it's a bit weird that the file dialog picks up the "natural sorting" setting that has been configured in Dolphin and offers no way to change it, but that's another topic).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After reading the thread I have the impression that naturalSorting will also gone. Then what to do? Replace calls to KGlobalSettings in Dolphin with calls to KConfig? From that discussion I did not understand what is the "proper way" for frameworks also.
It is sad that these settings will not be present in 5.0 (at least in 5.0). I'm now very happy that all KDirSortFilterProxyModel are sorted in a way that I like. It would be nice to put these settings into locale settings (and KCM), but seems like KLocale is removed also :(
</pre>
<br />
<p>- Eugene</p>
<br />
<p>On August 29th, 2013, 3:11 p.m. CEST, Eugene Shalygin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin and kdelibs.</div>
<div>By Eugene Shalygin.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2013, 3:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are number of people who want to have case sensitive sorting in file manager and file dialogs (that would be consistent with locale settings).
The proposed patch adds a property to KGlobalSettings (caseSensitiveSorting()) and the new signal sortingModeChanged(), which deprecates naturalSortingChanged(), so the clients can connect to only one event and do not resort their models twice (maybe and option for the event to pass the change reason would be useful?).
KDirSortFilterProxyModel is changed in a trivial manner to use new event and handle case sensitivity changes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=148550">https://bugs.kde.org/show_bug.cgi?id=148550</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/kernel/kglobalsettings.h <span style="color: grey">(96da20e)</span></li>
<li>kdeui/kernel/kglobalsettings.cpp <span style="color: grey">(2e3a7eb)</span></li>
<li>kfile/kdirsortfilterproxymodel.h <span style="color: grey">(63cf04c)</span></li>
<li>kfile/kdirsortfilterproxymodel.cpp <span style="color: grey">(34ddcd2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112328/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>