<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112294/">http://git.reviewboard.kde.org/r/112294/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 3rd, 2013, 10:20 p.m. UTC, <b>Oswald Buddenhagen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">given that there is no intention to make further feature releases of the kde workspace which will include kdm, i wonder why we'd go through the (potentially tedious) process of upstreaming this now?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The reason for sending this was to have one canonical implementation for multiseat support which is upstream.
Otherwise, any patches/bugreports must be coordinated downstream, which I really dislike.
Reason for pushing this into KDM is that:
a) KDM is here today and will stay for some time
b) this patch has been tested thoroughly
c) alternative DMs are not up to the job yet (SDDM) or introduce additional dependencies (GDM)
d) I want multiseat support in the DM now, not in a distant future</pre>
<br />
<p>- Stefan</p>
<br />
<p>On September 2nd, 2013, 11:34 p.m. UTC, Stefan Brüns wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Oswald Buddenhagen.</div>
<div>By Stefan Brüns.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2013, 11:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements dynamic multiseat in KDM. It follows the description in:
http://www.freedesktop.org/wiki/Software/systemd/writing-display-managers/
In case systemd is no found at compile time, nothing changes. If logind is not running, nothing changes. If no additional seats have been configured (some Plugable USB-GPUs are automatically added as additional seats), nothing changes.
In case there are additional seats beyond seat0, a reserved display is promoted to a local static one (and demoted if the seat is removed) and a new X-Server/greeter is spawned.
The code has been tested extensively, with a combination of [Radeon dedicated GPU|Intel iGPU], [Intel iGPU|Displaylink USB GPU] and others. For history of this patch, see https://bugzilla.redhat.com/show_bug.cgi?id=884271 and https://bugzilla.redhat.com/show_bug.cgi?id=975079</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Single seat system, several multiseat systems</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a3bdbb3)</span></li>
<li>cmake/modules/CMakeLists.txt <span style="color: grey">(117b3a5)</span></li>
<li>cmake/modules/FindSystemd.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdm/backend/CMakeLists.txt <span style="color: grey">(25f383f)</span></li>
<li>kdm/backend/client.c <span style="color: grey">(26bb0b4)</span></li>
<li>kdm/backend/dm.h <span style="color: grey">(64e106b)</span></li>
<li>kdm/backend/dm.c <span style="color: grey">(e0f1366)</span></li>
<li>kdm/backend/server.c <span style="color: grey">(d8dd6f3)</span></li>
<li>kdm/backend/session.c <span style="color: grey">(0e7901c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112294/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>