<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112009/">http://git.reviewboard.kde.org/r/112009/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime, kdewin and Pali Rohár.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2013, 2:24 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch intends to enable Windows exe/dll thumbnailing by using winapi. It derives from the unsubmitted patch from Pali Rohár from https://svn.reviewboard.kde.org/r/5156/ as a starting point. I've made a few adjustments on the original patch, split that patch into a common part and a icoutils-specific part, and then created the winapi-based part to replace the icoutils one on Windows (porting icoutils to windows wasn't going to be easy).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on a Windows 7 64-bit machine, with intel compiler (32-bit).
Tested using ico files and both 32-bit and 64-bit executables and dlls, including jumbo-size icons.
I've used QLibrary for all winapi functions in order to avoid issues with MinGW compiler, but I don't have a MinGW setup to check.
Not tested on *nix, but the original patch was not changed except for iterating order in the common part and namespacing.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/thumbnail/CMakeLists.txt <span style="color: grey">(b81339b)</span></li>
<li>kioslave/thumbnail/icoutils.h <span style="color: grey">(6468bc1)</span></li>
<li>kioslave/thumbnail/icoutils.cpp <span style="color: grey">(31db85d)</span></li>
<li>kioslave/thumbnail/icoutils_common.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kioslave/thumbnail/icoutils_icotools.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kioslave/thumbnail/icoutils_win.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kioslave/thumbnail/windowsexecreator.h <span style="color: grey">(a407982)</span></li>
<li>kioslave/thumbnail/windowsexecreator.cpp <span style="color: grey">(9e24aee)</span></li>
<li>kioslave/thumbnail/windowsexethumbnail.desktop <span style="color: grey">(f10efef)</span></li>
<li>kioslave/thumbnail/windowsimagecreator.h <span style="color: grey">(0b68cc6)</span></li>
<li>kioslave/thumbnail/windowsimagecreator.cpp <span style="color: grey">(08b063d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112009/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png">screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>