<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111852/">http://git.reviewboard.kde.org/r/111852/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 09030c36b2e5da244c41fde9afbc6eb75a21713b by David E. Narváez to branch KDE/4.11.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 5th, 2013, 3:14 p.m. UTC, David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, Albert Astals Cid and David Faure.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2013, 3:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Comment information is found in the XML data so needs to be loaded before returning property values. The same would apply for the Patterns property if you were to query that from the property name instead of the KMimeType::patterns() method.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Executed the same code posted in the bug report, here's the output:
("Name", "Comment", "Patterns", "Icon")
QVariant(QString, "PNG image")
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=322578">322578</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/services/kmimetype.cpp <span style="color: grey">(d748523)</span></li>
<li>kdecore/services/kmimetype_p.h <span style="color: grey">(6ffee71)</span></li>
<li>kdecore/tests/kmimetypetest.h <span style="color: grey">(c38b036)</span></li>
<li>kdecore/tests/kmimetypetest.cpp <span style="color: grey">(da32e2c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111852/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>