<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111776/">http://git.reviewboard.kde.org/r/111776/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9b0b5ec1a6396b051f65bf23cdf9d9949aa9c3ec by Dawit Alemayehu to branch KDE/4.11.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 2nd, 2013, 12:37 p.m. UTC, Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Aug. 2, 2013, 12:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is an improvement of https://git.reviewboard.kde.org/r/111585/ such that KIO operations also update URLs in the clipboard. As such, all KIO operations that rename, move or delete a file will always update the contents of the clipboard.
A couple of notes about this patch:
- KIO::trash was left out from this patch because I am unsure whether it should be treated like a delete or move operation.
- Move, rename and delete operations performed outside of KIO are not covered by this patch and as such will not update URLs in the clipboard. Dealing with non KIO modifications is outside the scope of this patch since it needs to be dealt with outside of KIO.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unite tests.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=134960">134960</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/clipboardupdater.cpp <span style="color: grey">(8ab9210)</span></li>
<li>kio/kio/clipboardupdater_p.h <span style="color: grey">(b07c320)</span></li>
<li>kio/kio/copyjob.cpp <span style="color: grey">(da19de5)</span></li>
<li>kio/kio/deletejob.cpp <span style="color: grey">(7178424)</span></li>
<li>kio/kio/job.cpp <span style="color: grey">(05d0ba2)</span></li>
<li>kio/kio/paste.cpp <span style="color: grey">(b4372ab)</span></li>
<li>kio/tests/CMakeLists.txt <span style="color: grey">(b570aac)</span></li>
<li>kio/tests/clipboardupdatertest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/tests/clipboardupdatertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/tests/fileundomanagertest.h <span style="color: grey">(e909bb7)</span></li>
<li>kio/tests/fileundomanagertest.cpp <span style="color: grey">(709938d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111776/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>