<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111883/">http://git.reviewboard.kde.org/r/111883/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 5th, 2013, 7:50 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, please also revert the NoGUI->GUI changes to the unittests.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9b0b5ec1a6396b051f65bf23cdf9d9949aa9c3ec by Dawit Alemayehu to branch KDE/4.11.</pre>
<br />
<p>- Dawit</p>
<br />
<p>On August 5th, 2013, 11:55 a.m. UTC, Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, Albert Astals Cid and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2013, 11:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Attached patch fixes runtime regression discussed here: http://lists.kde.org/?t=137554003100003&r=1&w=2. Basically, it restores the ability of unit tests to run without enabling GUI in QApplication.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/clipboardupdater.cpp <span style="color: grey">(821ef1e)</span></li>
<li>kio/kio/clipboardupdater_p.h <span style="color: grey">(e3d32bd)</span></li>
<li>kio/kio/copyjob.cpp <span style="color: grey">(fbe3cc7)</span></li>
<li>kio/kio/deletejob.cpp <span style="color: grey">(a822373)</span></li>
<li>kio/kio/fileundomanager.cpp <span style="color: grey">(f0f4168)</span></li>
<li>kio/kio/job.cpp <span style="color: grey">(c7c354f)</span></li>
<li>kio/kio/paste.cpp <span style="color: grey">(62490bb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111883/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>