<div dir="ltr">OK. I see why those tests failed and I fixed them not to anymore. Updating the clibpboard in KIO introduced a dependency on QtGui. Hence QTEST_KDEMAIN( KDirModelTest, NoGUI ) has to be changed to QTEST_KDEMAIN( KDirModelTest, GUI ).<div>
<br></div><div style>Hmm... I am curious if the dependency on QClipboard makes it difficult to split this into core/gui in frameworks?</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Aug 3, 2013 at 1:16 PM, Dawit A <span dir="ltr"><<a href="mailto:adawit@kde.org" target="_blank">adawit@kde.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hmm... I fail to see how my changes break those unit tests. Perhaps changing fileundomanager from NoGui to Gui did it? Anyhow, I will try to look into it.<div>
<div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">
On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid <span dir="ltr"><<a href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Dawit, kdelibs people, there are 4 tests that broke in very-close-to-release<br>
4.11 branch with a change from yesterday to kio.<br>
<br>
<a href="http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/" target="_blank">http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/</a><br>
<br>
Can you guys please have a look and fix those failing tests?<br>
<br>
Also please please please make sure you either run the tests before commiting<br>
changes so late in the release cycle *and* even if you run them please check<br>
with jenkins to see his opinion on your changes :)<br>
<br>
Cheers,<br>
Albert<br>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>