<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111795/">http://git.reviewboard.kde.org/r/111795/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 30th, 2013, 1:28 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not so sure about this. The 3 char restriction is there for performance, it might still work as expected on many system, yet cause stalling on others. At least doing the query on the first character seems *way* overdone.</pre>
</blockquote>
<p>On July 30th, 2013, 1:36 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compromise: for < 3 chars, trigger a 500ms timer.
So if a user types and waits he gets a reply but you won't burden the system with finding everything on the first key press.</pre>
</blockquote>
<p>On July 30th, 2013, 1:49 p.m. UTC, <b>Milo Mordaunt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see the point, a 500ms timer is probably a good idea, but other desktop environments definitely return applications after 1/2 characters, I think that sort of immediacy is important for the end user in general.
If some sort of learning system was implemented it might work better. Perhaps building a shortlist of commonly used applications to search after 1 or 2 characters? That would allow for better performance as well as making the system feel faster to the end user.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A timeout is not necessary; there is already an event compression delay in the user interface (which is where that belongs as in other places where runners are used programatically results should be instant).</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On July 30th, 2013, 12:46 p.m. UTC, Milo Mordaunt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Milo Mordaunt.</div>
<p style="color: grey;"><i>Updated July 30, 2013, 12:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The services runner now queries with terms of less than three characters.
Previously with a term of less than three characters this runner would be idle. Now it gives more immediate results, ie gp now returns gparted., and since it is only the services runner they are likely to be relevant.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested a variety of terms in my krunner, and the services runner appears to be working as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/runners/services/servicerunner.cpp <span style="color: grey">(7b292efe40bbddb23cfc317648db0e645c579879)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111795/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>