<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111633/">http://git.reviewboard.kde.org/r/111633/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 21st, 2013, 4:47 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is that qt change really needed? Otherwise we are a bit past the dependency freeze </pre>
</blockquote>
<p>On July 21st, 2013, 5:02 p.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CMakeLists.txt already requires Qt 4.8.0.</pre>
</blockquote>
<p>On July 21st, 2013, 10:39 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But isn't the content of CMakeLists.txt for kdelibs and the content in that file for something using kdelibs, right? Do we need to mandate 4.8 on them too? In other words, could i compile a program against qt 4.5 and a kdelibs compiled with qt 4.8?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I understand r1023024, the check here was added to allow to require a higher version than kdelibs does, e.g. today an application could require Qt 4.8.2, e.g. because of bugs with older Qt versions, while kdelibs itself just mandates 4.8.0.
Also, if you compile your program against Qt 4.5 you can get missing symbols when running it, because kdelibs was linked against Qt 4.8. See also r927156.
On the other hand, if we allowed that before, we can keep it. I just had the impression it was simply forgotten to be updated.</pre>
<br />
<p>- Christoph</p>
<br />
<p>On July 21st, 2013, 4:40 p.m. UTC, Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System, kdelibs and Alexander Neundorf.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated July 21, 2013, 4:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure at which point in time we update the KDE version.
Additionally, I changed the required Qt version, in the hope that build system maintainers find more spots where version updates might be required.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindKDE4Internal.cmake <span style="color: grey">(98a6f48)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111633/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>