<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111335/">http://git.reviewboard.kde.org/r/111335/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 13th, 2013, 6:32 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Almost there, thanks.
I'm surprised by the dispatch (to call one of the many uidelegate methods), followed by an un-dispatch (what's the term?), i.e. these many methods all end up calling the same method anyway.... I can see how it makes the uidelegate api look nicer, but this is all internal, nobody else than the slave should end up calling these methods (if apps need messageboxes they can just use KMessageBox directly). I'm not vetoing this solution, maybe you can leave it, I'm just wondering what's the purpose.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well to be honest I just simply hate marking publicly declared APIs as internal. That is why I did what I did. In hindsight though I should resisted my own dislike and and simply created the public API and marked it internal. You are right. The rolling and unrolling (making up words here) of the dispatch call make little sense, especially when it is done to avoid ones own pet peeve.</pre>
<br />
<p>- Dawit</p>
<br />
<p>On July 13th, 2013, 1:30 a.m. UTC, Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated July 13, 2013, 1:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch addresses one of the oldest bugs in KIO. Due to the muti-process nature of KIO, if any of the ioslaves encounter something that requires user input, the user might end up getting prompted multiple times. The best example of this is SSL error warnings sent to the client by kio_http. The patch completely resolves this problem using the same approach as kpasswdserver, but without the need for an additional kded process.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Visit a site that throws up SSL warnings and causes KIO to show more than one error dialog.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=154100">154100</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=265228">265228</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/CMakeLists.txt <span style="color: grey">(4854829)</span></li>
<li>kio/kio/job_p.h <span style="color: grey">(0c1fd64)</span></li>
<li>kio/kio/jobuidelegate.h <span style="color: grey">(25e0728)</span></li>
<li>kio/kio/jobuidelegate.cpp <span style="color: grey">(85679c2)</span></li>
<li>kio/kio/scheduler.cpp <span style="color: grey">(802f8b8)</span></li>
<li>kio/kio/slaveinterface.h <span style="color: grey">(4bfcec8)</span></li>
<li>kio/kio/slaveinterface.cpp <span style="color: grey">(aa0fc44)</span></li>
<li>kio/kio/slaveinterface_p.h <span style="color: grey">(e31ec5e)</span></li>
<li>kio/kio/usernotificationhandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/usernotificationhandler_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111335/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>