<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111402/">http://git.reviewboard.kde.org/r/111402/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ff1e67e11800107a81cba3f290832b85f97a0513 by Jekyll Wu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 5th, 2013, 2:59 p.m. UTC, Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Ben Cooksley.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated July 5, 2013, 2:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The aim is that in the future we can disable outdated versions in the systemsettings product so that bugs.kde.org will reject crash reports from outdated versions.
I know systemsettings itself hasn't really changed much between releases. But since systemsettings is the main container of various KCMs (another one is kcmshell4), and the crashes caused by those KCMs are reflected as crashes of systemsettings, it becomes necessary for systemsetings to use a version scheme which can be used to identify different releases. The current never changing '1.0' version doesn't suit that need.
Also see my similar requests against plasma-desktop[1] and dolphin[2].
[1] https://git.reviewboard.kde.org/r/109906/
[2] http://lists.kde.org/?l=kfm-devel&m=137120231924936&w=2
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>systemsettings/app/main.cpp <span style="color: grey">(1656179)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111402/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>