<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111291/">http://git.reviewboard.kde.org/r/111291/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Andre</p>
<br />
<p>On June 28th, 2013, 6:05 p.m. UTC, Patrick von Reth wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, kdewin and Solid.</div>
<div>By Patrick von Reth.</div>
<p style="color: grey;"><i>Updated June 28, 2013, 6:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) Fixes ui blocking
2) Fixes problems where some drives could result in a unusable KDE system.
3) The wmi backend was "broken" from the beginning because the all wmi calls depend on the wmi host which can be just to slow for intense usage.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing has been don on windows.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=178455">178455</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=306994">306994</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=314317">314317</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid/solid/backends/win/winstorageaccess.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winstorageaccess.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winprocessor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winprocessor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winopticaldrive.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winopticaldrive.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winopticaldisc.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winopticaldisc.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/wininterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/wininterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/wingenericinterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/wingenericinterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/windevicemanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/windevicemanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/windevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/windevice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winblock.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winblock.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winbattery.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winbattery.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winacadapter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winacadapter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/CMakeLists.txt <span style="color: grey">(a5aba96b1c8b3f3147e9653ff5f244ea03cf2211)</span></li>
<li>CMakeLists.txt <span style="color: grey">(3d6c6beb8826ed98380d7ba9fa68efe2fde2fcb1)</span></li>
<li>solid/solid/backends/win/winstoragedrive.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winstoragedrive.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winstoragevolume.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/win/winstoragevolume.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/managerbase.cpp <span style="color: grey">(beaeac5d39198ce5aa53bea23a032621fa934088)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111291/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>