<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111206/">http://git.reviewboard.kde.org/r/111206/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 24th, 2013, 8:38 a.m. UTC, <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch Dawit! The approach looks good to me, from my point of view this can go in unless David has any objections. One little question though: is there a reason why you moved the "Trash/Delete"-related code to a different location in DolphinContextMenu::openItemContextMenu()? This makes the diff larger, and it becomes harder to understand what's going on if anyone investigates the file's history at some point in the future.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I moved the code into openItemContextMenu because the change requires access to KFileItemListProperties for checking capabilities. As such the option I had was to either move the code where I did or add a parameter to the insertDefaultItemActions for passing KFileItemListProperties. I just chose to do the latter simply because KFileItemListProperties already exists in openItemContextMenu and no other code in insertDefaultItemActions requires it. I can change it to the latter approach since I have no preference about this.</pre>
<br />
<p>- Dawit</p>
<br />
<p>On June 24th, 2013, 5:58 a.m. UTC, Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps, David Faure and Frank Reininghaus.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated June 24, 2013, 5:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch fixes which one of the remove actions are shown in both Dolphin and Konqueror. Its main goal is not to show the "Move To Trash" for remote protocols, e.g. sftp, smb. As such the patch does the following:
1.) For local files, show both the "Move To Trash" and "Delete" actions if the "ShowDeleteCommand" global option is set. Pressing Shift key will have no effect.
2.) For local files, show only "Move To Trash" when the "ShowDeleteCommand" global option is not set. Pressing the Shift key will change the action to "Delete".
3.) For remote files, only show the "Delete" action. Never show the "Move To Trash" action.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=261762">261762</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphincontextmenu.cpp <span style="color: grey">(7073dbf)</span></li>
<li>dolphin/src/dolphinpart.cpp <span style="color: grey">(642b150)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111206/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>