<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111090/">http://git.reviewboard.kde.org/r/111090/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Romário Rios.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since, according to lxr, both these classes aren't used by anyone, I just marked them as deprecated and moved them to kde4support.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdelibs compiles after the move. There weren't any tests for them anywhere and I didn't bother to write any, since they're being deprecated -- I assume that's OK.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(cb30283)</span></li>
<li>kdeui/widgets/kstringvalidator.h <span style="color: grey">(01dbec6)</span></li>
<li>kdeui/widgets/kstringvalidator.cpp <span style="color: grey">(c4fcc21)</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(9254283)</span></li>
<li>kio/kfile/kfilemetainfowidget.h <span style="color: grey">(eaebcc8)</span></li>
<li>kio/kfile/kfilemetainfowidget.cpp <span style="color: grey">(d0f74df)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(f89e845)</span></li>
<li>staging/kde4support/src/kdeui/kstringvalidator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/kstringvalidator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kio/kfilemetainfowidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kio/kfilemetainfowidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111090/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>