<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110922/">http://git.reviewboard.kde.org/r/110922/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't like the duplication very much (can't the old method call the V2 method, if the only difference is the return value, which the old method would then ignore?).
Otherwise OK, as it's kind of temporary anyway. It just increases the risks of someone fixing a bug in one copy and not the other, so if we can avoid the duplication, it's better.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110922/diff/1/?file=149277#file149277line56" style="color: black; font-weight: bold; text-decoration: underline;">lib/konq/konq_operations.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">enum</span> <span class="n">Operation</span> <span class="p">{</span> <span class="n">TRASH</span><span class="p">,</span> <span class="n">DEL</span><span class="p">,</span> <span class="n">COPY</span><span class="p">,</span> <span class="n">MOVE</span><span class="p">,</span> <span class="n">LINK</span><span class="p">,</span> <span class="n">EMPTYTRASH</span><span class="p">,</span> <span class="n">STAT</span><span class="p">,</span> <span class="n">MKDIR</span><span class="p">,</span> <span class="n">RESTORE</span><span class="p">,</span> <span class="n">UNKNOWN</span><span class="p">,</span> <span class="n">PUT</span> <span class="p">};</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">enum</span> <span class="n">Operation</span> <span class="p">{</span> <span class="n">TRASH</span><span class="p">,</span> <span class="n">DEL</span><span class="p">,</span> <span class="n">COPY</span><span class="p">,</span> <span class="n">MOV<span class="hl">E</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">RENAM</span>E</span><span class="p">,</span> <span class="n">LINK</span><span class="p">,</span> <span class="n">EMPTYTRASH</span><span class="p">,</span> <span class="n">STAT</span><span class="p">,</span> <span class="n">MKDIR</span><span class="p">,</span> <span class="n">RESTORE</span><span cla
ss="p">,</span> <span class="n">UNKNOWN</span><span class="p">,</span> <span class="n">PUT</span> <span class="p">};</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change is BIC. Add the new flag at the end of the list.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On June 9th, 2013, 10 p.m. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, KDE Base Apps, David Faure, and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated June 9, 2013, 10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change the data in the model before the real renaming is done by KonqOperations::rename(),
but when the rename operation fails, revert the data changes in the model.
The problem is that DolphinView::slotRoleEditingFinished() changes the data in the model *before* the actual renaming is performed by KonqOperations/KIO.
But we need this approach for the following cases:
* Immediate feedback from the users point of view (No delay between finish renaming and DolphinView updates)
* Missing file system/dir lister signals, when there is no file system notification system (ftp, ssh, ...)
A lot of code in konq_operations.h and konq_operations.cpp is just copy and paste, to guarantee binary compatibility. (added some TODOs for KF 5.0)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works for me.
Tested with a remote ssh file system on a virtual machine.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319119">319119</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/dolphinview.h <span style="color: grey">(5a70c55)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: grey">(9a4b863)</span></li>
<li>lib/konq/konq_operations.h <span style="color: grey">(a9aec89)</span></li>
<li>lib/konq/konq_operations.cpp <span style="color: grey">(cbb058c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110922/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>