<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110898/">http://git.reviewboard.kde.org/r/110898/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 9th, 2013, 8:38 a.m. UTC, <b>Christophe Giboudeaux</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">plasma/desktop/applets/kickoff/core/config-kickoff-applets.h.cmake:#cmakedefine HAVE_STRIGIDBUS 1
this line is not needed anymore with this change</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks - that file consists only of that line. Should I also remove the file and the line in plasma/desktop/applets/kickoff/CMakeLists.txt that refers to it, or is it needed for some other reason?</pre>
<br />
<p>- Simeon</p>
<br />
<p>On June 9th, 2013, 1:53 a.m. UTC, Simeon Bird wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Nepomuk.</div>
<div>By Simeon Bird.</div>
<p style="color: grey;"><i>Updated June 9, 2013, 1:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So far as I can see, the only thing depending on strigi still in kde-workspace is a strigi plugin called FontAnalyzer,
and, I think, this doesn't do much now nepomuk doesn't use strigi. (I'm curious as to why it was in kde-workspace
in the first place, instead of in strigi, actually)
This patch removes the strigi dependency and FontAnalyzer from kde-workspace.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, ran</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/kfontinst/CMakeLists.txt <span style="color: grey">(1ba461cf9c09a0dba3af13b67f585db08c7da77a)</span></li>
<li>CMakeLists.txt <span style="color: grey">(d233cf4a745ea1c6caf0b560539a68f71ab41020)</span></li>
<li>kcontrol/kfontinst/strigi-analyzer/CMakeLists.txt <span style="color: grey">(ab5643ec4f1ce47f17b598e016300d51e181c946)</span></li>
<li>kcontrol/kfontinst/strigi-analyzer/FontEngine.h <span style="color: grey">(028e971f34a52b4bda4df8130cbe2af688c45e8b)</span></li>
<li>kcontrol/kfontinst/strigi-analyzer/FontEngine.cpp <span style="color: grey">(8e00bd550c9e2a3e1b25ef6cf6a3d510576e67d8)</span></li>
<li>kcontrol/kfontinst/strigi-analyzer/FontThroughAnalyzer.h <span style="color: grey">(0e0a7a8eac99c85ed21d9ab3305a2a75b18e9ec9)</span></li>
<li>kcontrol/kfontinst/strigi-analyzer/FontThroughAnalyzer.cpp <span style="color: grey">(ffa22a9ad09617b6ab87652ee0a9f246e0502227)</span></li>
<li>plasma/desktop/applets/kickoff/CMakeLists.txt <span style="color: grey">(e9e288866ecdcfd7aa35c086dfe78d4252748995)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110898/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>