<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103168/">http://git.reviewboard.kde.org/r/103168/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, Thomas Braxton and Oswald Buddenhagen.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated June 7, 2013, 1:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reimplemented revertToDefault completely after Oswald's suggestions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KConfig: properly implement revertToDefault().</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KConfig: properly implement revertToDefault().
Now it really removes the entry from the local file, instead of copying
the value from the global file ("defaults" file, in internal terminology).
This implements a long-standing TODO, which is now removed from the TODO file.
And it doesn't mark the KConfig as dirty if there's no local entry,
which makes closing kmail composer windows a LOT faster.
REVIEW: 103168</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/config/TODO <span style="color: grey">(158a78adbcd49fafd2863155b42f354a413b0136)</span></li>
<li>kdecore/config/kconfig.h <span style="color: grey">(51381cab586d44170ee614b0d43b0d333713103d)</span></li>
<li>kdecore/config/kconfig.cpp <span style="color: grey">(048605d052595b3f357c0fac6117e91a3b7be0b3)</span></li>
<li>kdecore/config/kconfig_p.h <span style="color: grey">(7751242b47abb9a9dd21c0553ee455c356b8ccc4)</span></li>
<li>kdecore/config/kconfigdata.h <span style="color: grey">(e5dd7da5888fbc6523b544de05732a4559c807e1)</span></li>
<li>kdecore/config/kconfigdata.cpp <span style="color: grey">(8f837fb8eec896c1ceb245bc6854cdfba55cce4b)</span></li>
<li>kdecore/config/kconfiggroup.cpp <span style="color: grey">(9e73eb71480cdd023b232442409ea0c25042072a)</span></li>
<li>kdecore/config/kconfigini.cpp <span style="color: grey">(6e2021c1d79f14862e1ddbe1cccda6fa6e2121f7)</span></li>
<li>kdecore/tests/kconfigtest.h <span style="color: grey">(3b01c66fd49cda833044dfcb5f2b51c24da7f18b)</span></li>
<li>kdecore/tests/kconfigtest.cpp <span style="color: grey">(e5d2e80da0685615a0028ccd7254487664ffc6b0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103168/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>