<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110799/">http://git.reviewboard.kde.org/r/110799/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 8b8bb0ad20feb2712717ec1f5d6df06bdc4e8d5a by Burkhard Lück to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 3rd, 2013, 3:12 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated June 3, 2013, 3:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since may 2012 the babelfish service is no longer available, it was moved to Bing translator
and can't be used no more.
I changed default translator to Google, which is already used by kdepim/pimcommon/translator/
Translating a selection did not work with the old code, so I used the code
from Laurent Montel in the pim translator.
Btw. pimcommon lib has a nice translation bar, could probably be reused here.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in master + 4.10 in HTML + WebKit view modes
Result is the same as using translate.google.com direct with text or an url.
In master in HTML mode a JavaScript Error Warning pops up:
"An error occurred while attempting to run a script on this page.
....
Type-Error: Attempt to use a non-function object or a value as a function."</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konq-plugins/babelfish/plugin_babelfish.cpp <span style="color: grey">(c962f18)</span></li>
<li>konq-plugins/babelfish/plugin_babelfish.desktop <span style="color: grey">(267ac60)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110799/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>