<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108442/">http://git.reviewboard.kde.org/r/108442/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108442/diff/2/?file=144151#file144151line879" style="color: black; font-weight: bold; text-decoration: underline;">kio/kfile/kpropertiesdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KFilePropsPlugin::KFilePropsPlugin( KPropertiesDialog *_props )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">876</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">b<span class="hl">s</span>ize</span> <span class="o">=</span> <span class="mi">66</span> <span class="o">+</span> <span class="mi">2</span> <span class="o">*</span> <span class="n">iconButton</span><span class="o">-></span><span class="n">style</span><span class="p">()</span><span class="o">-></span><span class="n">pixelMetric</span><span class="p">(</span><span class="n">QStyle</span><span class="o">::</span><span class="n">PM_ButtonMargin</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">879</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="kt">int</span> <span class="n">b<span class="hl">uttonS</span>ize</span> <span class="o">=</span> <span class="n"><span class="hl">qRound</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="p"><span class="hl">(</span></span><span class="mi">66</span> <span class="o">+</span> <span class="mi">2</span> <span class="o">*</span> <span class="n">iconButton</span><span class="o">-></span><span class="n">style</span><span class="p">()</span><span class="o">-></span><span class="n">pixelMetric</span><span class="p">(</span><span class="n">QStyle</span>
<span class="o">::</span><span class="n">PM_ButtonMargin</span><span class="p">)<span class="hl">)</span></span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span
class="hl"> </span><span class="n"><span class="hl">dpiRatio</span></span><span class="hl"> </span><span class="p"><span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">18*dpiRatio + 2*iconButton->style()... ?
The code looks suspisious enough, though (the button should have a sanme resizePolicy and adjust to the loaded icon automatically, yesno?) *shrug*</pre>
</div>
<br />
<p>- Thomas</p>
<br />
<p>On May 15th, 2013, 7:37 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated May 15, 2013, 7:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The KIconButton and the other occurences assume that the icon size for desktop icons is always 48x48. This assumption is wrong.
This patch makes KPropertiesDialog use the proper IconSize.
There are other places that need fixing too (eg. Dolphin's Place edit dialog or KMenuEdit) which I will fix later as well.
So, with KDE Frameworks at the horizon and kdelibs frozen, does this mean, when I am re-writing the KIconDialog to be more userfriendly, use an UI file, introduce new strings, etc this cannot go into master but only frameworks branch?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup, you won't notice any difference with default settings but with higher icon size and font scales perfectly and looks good. See screenshot.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kfile/kicondialog.cpp <span style="color: grey">(73a7449)</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(b4cd8ee)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108442/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconbutton.png">KPropertiesDialog with Retina settings</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>