<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110687/">http://git.reviewboard.kde.org/r/110687/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and George Kiagiadakis.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated May 30, 2013, 7:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improve wording: use less offensive words.
Fix various code style issues</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As I have said in https://bugs.kde.org/show_bug.cgi?id=315073#c3 , Bugzilla's new and nice behavior (since 4.2.5) of rejecting reports against disabled versions brings a new usability problem to DrKonqi: users spend value time in downloading debug symbols, generating the backtrace, writing all information he/she can recall, but in the end only to find an error dialog telling them (in a not so clear and friendly way) that bugs.kde.org won't accept his/her report.
I would propose making version checking the very first step in the reporting assistant: a perfect bug report against an outdated version is still useless.
The patch has been created for sometime and works, but unfortunately I don't have much time for coding since then, so it is not as good as what I have planned to make it to be. Nevertheless, I think it is still a good improvement of the current situation.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=315073">315073</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/CMakeLists.txt <span style="color: grey">(39833d7)</span></li>
<li>drkonqi/drkonqi_globals.h <span style="color: grey">(d5f098a)</span></li>
<li>drkonqi/productmapping.h <span style="color: grey">(f926c9d)</span></li>
<li>drkonqi/productmapping.cpp <span style="color: grey">(f4e59e5)</span></li>
<li>drkonqi/reportassistantdialog.cpp <span style="color: grey">(c296059)</span></li>
<li>drkonqi/reportassistantpages_bugzilla_versioncheck.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>drkonqi/reportassistantpages_bugzilla_versioncheck.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>drkonqi/reportinterface.h <span style="color: grey">(c7e374e)</span></li>
<li>drkonqi/reportinterface.cpp <span style="color: grey">(4190c40)</span></li>
<li>drkonqi/ui/assistantpage_versioncheck.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110687/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/28/drkonqi-version-checking.png">rejecting disabled version</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/30/bugzilla-version-cheking-improved.png">reject disabled versions (revised edition)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>