<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110649/">http://git.reviewboard.kde.org/r/110649/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 26th, 2013, 2:15 p.m. UTC, <b>Fredrik Höglund</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110649/diff/1/?file=146351#file146351line58" style="color: black; font-weight: bold; text-decoration: underline;">kimgio/webp.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">uint8_t</span> <span class="o">*</span><span class="n">imageData</span> <span class="o">=</span> <span class="n">WebPDecodeRGBA</span><span class="p">(</span><span class="k">reinterpret_cast</span><span class="o"><</span><span class="k">const</span> <span class="kt">uint8_t</span><span class="o">*></span><span class="p">(</span><span class="n">data</span><span class="p">.</span><span class="n">constData</span><span class="p">()),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not particularly efficient. WebPDecodeBGRAInto() can decode directly into a QImage without using an intermediate buffer.</pre>
</blockquote>
<p>On May 30th, 2013, 10:09 a.m. UTC, <b>Martin Koller</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I understand the QImage documentation, I can not use this: "You cannot use the uchar* pointer directly, because the pixel format depends on the byte order on the underlying platform. Use qRed(), qGreen(), qBlue(), and qAlpha() to access the pixels."
I understood it as: WebPDecodeRGBA() delivers always 4 consecutive bytes as RGBA, regardless of the endianess of the platform, but QImage::bits() returns a pointer to the data which contains the bytes in the order of the platform, which might be different than what WebPDecodeRGBA() delivers.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QImage uses a packed-pixel format where the components are packed in 32-bit words in ARGB order. It thus follows that the byte order is BGRA on little-endian, and ARGB on big-endian.
The WebP functions are array-based, so you have to use WebPDecodeBGRAInto() on little-endian and WebPDecodeARGBInto() on big-endian.</pre>
<br />
<p>- Fredrik</p>
<br />
<p>On May 30th, 2013, 10:11 a.m. UTC, Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated May 30, 2013, 10:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru
This is what was submitted before in https://git.reviewboard.kde.org/r/106300/ but it was suggested to move it to kde-runtime</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9f1f886)</span></li>
<li>kimgio/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/webp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/webp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/webp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kimgio/webp.xml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110649/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>