<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110423/">http://git.reviewboard.kde.org/r/110423/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110423/diff/2/?file=145629#file145629line155" style="color: black; font-weight: bold; text-decoration: underline;">kurifilter-plugins/ikws/searchproviderdlg.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void SearchProviderDialog::slotButtonClicked(int button) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">154</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">keys</span> <span class="o">!=</span> <span class="n">m_provider</span><span class="o">-></span><span class="n">keys</span><span class="p">()</span> <span class="o">||</span> <span class="n">charset</span> <span class="o">!=</span> <span class="n">m_provider</span><span class="o">-></span><span class="n">charset</span><span class="p">()));</span><span class="ew"> </span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">155</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">keys</span> <span class="o">!=</span> <span class="n">m_provider</span><span class="o">-></span><span class="n">keys</span><span class="p">()</span> <span class="o">||</span> <span class="n">charset</span> <span class="o">!=</span> <span class="n">m_provider</span><span class="o">-></span><span class="n">charset</span><span class="p">()));</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please remove this whitespace though it was already there.</pre>
</div>
<br />
<p>- Dawit</p>
<br />
<p>On May 28th, 2013, 6:37 p.m. UTC, Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated May 28, 2013, 6:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds a 'Insert query placeholder' button to the add/modify web shortcut dialog.
-Clicking this button inserts \{@} in the shortcut URL lineEdit.
-The button is only enabled when the shortcut URL lineEdit has focus.
This makes it easy to add new web shortcuts. Users don't have to remember and type the query placeholder.
The eventfilter complicates this patch a lot. But there is no slot to detect if a lineedit has focus.
We could drop it but it looks messy when the button is always enabled.
I feel the tooltip text can be improved. Any suggestions from a native English speaker?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a new shortcut.
Changed focus to and from different widgets.
Inserted placeholder at the end of the link and in the middle.
Modified a shortcut.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=146879">146879</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kurifilter-plugins/ikws/searchproviderdlg.h <span style="color: grey">(e931e11)</span></li>
<li>kurifilter-plugins/ikws/searchproviderdlg.cpp <span style="color: grey">(5f40f5f)</span></li>
<li>kurifilter-plugins/ikws/searchproviderdlg_ui.ui <span style="color: grey">(d75ac5b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110423/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/21/before-After2.png">Berfore vs After</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/28/After3.png">Alternative look</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>