<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110663/">http://git.reviewboard.kde.org/r/110663/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Ivan Čukić.</div>
<div>By Simon Persson.</div>
<p style="color: grey;"><i>Updated May 29, 2013, 10:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Check the ksmserver config file for which session should be restored. Manually saved session gets saved in separate config file entries.
I was also trying to make kamd crash-safe when ksmserver is set to restore manually saved session, I tried adding a cleanShutdown entry to the config file, it would get set to false after restoring a session and to true in the Activities destructor. I did some changes to main() so that the destructors would get called. Unfortunately it was still not enough as it seems kamd is not asked nicely to quit on logout, but rather killed.
Decided to keep the changes so that destructors are called at least in the case of a "nice" shutdown.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only save state of currently running session when asked to by the session manager. This will support activities in the "restore manually saved session" function of the session manager.
Relies on review https://git.reviewboard.kde.org/r/110662/
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested by running a full kde session compiled from master. Saw that with "restore previous session" set there was no regression (only change would be that a power failure or crash of ksmserver would now result in the current state of running activities not getting saved, hardly critical I would say).
Also saw that "restore manually saved session" now restores activities as they were when the session was saved.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/service/Activities.cpp <span style="color: grey">(9e09c9f)</span></li>
<li>src/service/Activities_p.h <span style="color: grey">(5f3304d)</span></li>
<li>src/service/Application.h <span style="color: grey">(2e84b27)</span></li>
<li>src/service/Application.cpp <span style="color: grey">(54cbf8a)</span></li>
<li>src/service/jobs/ksmserver/KSMServer.h <span style="color: grey">(7e42e56)</span></li>
<li>src/service/jobs/ksmserver/KSMServer.cpp <span style="color: grey">(888df1f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110663/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>