<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110084/">http://git.reviewboard.kde.org/r/110084/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110084/diff/2/?file=142580#file142580line478" style="color: black; font-weight: bold; text-decoration: underline;">kioslave/ftp/ftp.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool Ftp::ftpOpenControlConnection( const QString &host, int port )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">478</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sErrorMsg</span> <span class="o">=</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"%1<span class="hl">.</span></span><span class="se"><span class="hl">\n\n</span></span><span class="s"><span class="hl">Reason:</span> %2"</span><span class="p">,</span> <span class="n">host</span><span class="p">,</span> <span class="n">psz</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">478</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sErrorMsg</span> <span class="o">=</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"%1<span class="hl"> (Error</span> %2<span class="hl">)</span>"</span><span class="p">,</span> <span class="n">host</span><span class="p">,</span> <span class="n"><span class="hl">QString</span></span><span class="p"><span class="hl">(</span></span><span class="n">psz</span><span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">trimmed</span></span><span class="p"><span class="hl">())</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QString(psz) looks like a glaring encoding issue.
It should be QString::fromUtf8, fromLatin1, fromLocal8Bit ... or possibly KRemoteEncoding. That's probably the best option (same encoding as the filenames themselves, and user-configurable).
Yes, the bug was kind of there already :-)</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On May 7th, 2013, 7:48 a.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated May 7, 2013, 7:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove linebreaks and trim the message so the ugly linebreak at the end disappears.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works and looks much nicer :)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=318079">318079</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/ftp/ftp.cpp <span style="color: grey">(b0868d8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110084/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png">Before</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png">After</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>