<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110663/">http://git.reviewboard.kde.org/r/110663/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110663/diff/1/?file=146516#file146516line521" style="color: black; font-weight: bold; text-decoration: underline;">src/service/Activities.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">506</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">Activities</span><span class="o">::</span><span class="n">Private</span><span class="o">::</span><span class="n">saveSessionState</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This will break things if kamd has not been shut down by ksmserver. (or if it crashes - it will not restart in the activity it was in beforehands)
It could use a separate config variable and check those on start.</pre>
</div>
<br />
<p>- Ivan</p>
<br />
<p>On May 27th, 2013, 10:02 a.m. UTC, Simon Persson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Ivan Čukić.</div>
<div>By Simon Persson.</div>
<p style="color: grey;"><i>Updated May 27, 2013, 10:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only save state of currently running session when asked to by the session manager. This will support activities in the "restore manually saved session" function of the session manager.
Relies on review https://git.reviewboard.kde.org/r/110662/
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested by running a full kde session compiled from master. Saw that with "restore previous session" set there was no regression (only change would be that a power failure or crash of ksmserver would now result in the current state of running activities not getting saved, hardly critical I would say).
Also saw that "restore manually saved session" now restores activities as they were when the session was saved.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/service/Activities.cpp <span style="color: grey">(9e09c9f)</span></li>
<li>src/service/Activities_p.h <span style="color: grey">(5f3304d)</span></li>
<li>src/service/jobs/ksmserver/KSMServer.h <span style="color: grey">(7e42e56)</span></li>
<li>src/service/jobs/ksmserver/KSMServer.cpp <span style="color: grey">(888df1f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110663/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>