<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110633/">http://git.reviewboard.kde.org/r/110633/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bugzilla itself (since 4.2.5) already rejects any attempt against disabled versions. So even without this patch, DrKonqi users won't be able to create crash report against disabled versions in the end. From developers POV, you don't need to worry about that.
The problem is usability for users. I'm not sure this reused error dialog is more informative than the existing one in https://bugs.kde.org/attachment.cgi?id=78600&action=edit. So I'm against this patch in its current simple form.
As said in [1][2], I'm working on a patch for the usability improvement and plan to make it into 4.11. I will create a review request today or tomorrow.
[1] https://bugs.kde.org/show_bug.cgi?id=315073#c3
[2] https://bugs.kde.org/show_bug.cgi?id=318769#c1</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On May 24th, 2013, 2:54 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime, Plasma, Ben Cooksley, and Myriam Schweingruber.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 24, 2013, 2:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bugzilla provides a feature to disable versions. This means that the developers do not want to have further reports for this version. Any crash report is by that not helpful any more. So let's just disable reporting crashes for such bugs.
If this change gets accepted I intend to backport it to 4.10 and to inform kde-packagers about it to ship it as an update to *all* version they support. This would automatically prevent most duplicates report we get e.g. for KWin.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See https://bugs.kde.org/show_bug.cgi?id=320217 - the bug was created with version 4.10.60. Afterward the version got disabled and DrKonqi doesn't allow me to report crashes for this version anymore.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/reportinterface.cpp <span style="color: grey">(4190c40)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110633/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/24/drkonqi-disabled.png">With it disabled</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>