<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109246/">http://git.reviewboard.kde.org/r/109246/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 23rd, 2013, 9:16 a.m. UTC, <b>Patrick von Reth</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for the missing feedback we already apply your patch locally and its already part of our release so please ship it.
BIG THANKS</pre>
</blockquote>
<p>On May 23rd, 2013, 12:49 p.m. UTC, <b>Michel Ludwig</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok. As I haven't done any commits to kdelibs in a while, does anybody know what the current commit policy is, i.e. to which branch(es) should I commit?</pre>
</blockquote>
<p>On May 24th, 2013, 2:07 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You should commit to KDE/4.10. It's a fix anyway, no?</pre>
</blockquote>
<p>On May 24th, 2013, 2:46 p.m. UTC, <b>Michel Ludwig</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, committing to KDE/4.10 is fine. But what about other branches, like 'master' or 'framework'. Commit, cherry-pick, merge, or nothing of the three? :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">merge KDE/4.10 into master and master into frameworks</pre>
<br />
<p>- Albert</p>
<br />
<p>On March 2nd, 2013, 4:54 p.m. UTC, Michel Ludwig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Michel Ludwig.</div>
<p style="color: grey;"><i>Updated March 2, 2013, 4:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Absolute paths can, for example, have the form "E:/MyDocuments/test/test.tex" on Windows. Currently, KUrl::_relativePath assumes that
"E:/MyDocuments/test/test.tex" is a relative path and
KUrl::relativePath("E:/MyDocuments/", "E:/MyDocuments/test/test.tex")
will therefore return "E:/MyDocuments/test/test.tex" instead of "test/test.tex". The attached patch fixes this issue.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/io/kurl.cpp <span style="color: grey">(ef2ba12)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109246/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>