<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110388/">http://git.reviewboard.kde.org/r/110388/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could I get an update on this?
This is mostly working for me. Some thumbnailers need to be recompiled but there is no breakage if they use the old cache for now.
If this change is to intrusive for frozen kdelibs I could make it frameworks only. (although it is a bugfix imho)</pre>
<br />
<p>- Maarten</p>
<br />
<p>On May 11th, 2013, 2:40 p.m. UTC, Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated May 11, 2013, 2:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The freedesktop spec[0] has changed the default location of the thumbnail cache directory.
Now thumbnails are saved in $XDG_CACHE_HOME/thumbnails instead of ~/.thumbnails/
GNOME has already made this change.
Some applications[1] and documentation[2] (maybe thumbnailers) will have to be changed to adapt to this new directory. If this patch is accepted I'll make the needed changes.
For frameworks we can use QStandardPaths::CacheLocation, I'll post a separate review for that.
All thumbnails will have to be regenerated. We could symlink the directory?
Is fromLocal8Bit correct or is UTF8 needed now?
[0] http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html
[1] configurepreviewdialog.cpp in Dolphin
[2]http://techbase.kde.org/KDE_System_Administration/XDG_Filesystem_Hierarchy#Thumbnails</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove ~/.thumbnails/
Run dolphin with previews: thumbnails are created in .cache/thumbnails/
Repeated with XDG_CACHE_HOME=~/.cachetestdir/
Thumbnails in .cachetestdir/thumbnails/
Not tested: gwenview and digikam.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319528">319528</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/previewjob.cpp <span style="color: grey">(01b674d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110388/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>