<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110367/">http://git.reviewboard.kde.org/r/110367/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 18th, 2013, 1:33 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ShipIt from anyone?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code looks fine from my point of view.
I'm not the maintainer of kdeui though, so I won't give it a ship it for now.</pre>
<br />
<p>- Ben</p>
<br />
<p>On May 9th, 2013, 11:05 p.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated May 9, 2013, 11:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch by Pau ages ago, Lydia wants to push for it again.
Note that i still find it ugly, but i'm not the kdeui maintainer, so i'll leave it to someone else to discuss.
Not sure if the StandardAction enum addition should be at the end in case someone is storing those enums in a file or something.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran okular, saw the new menu entry, it did stuff.
Ran ksnapshot (that doesn't use xmlgui), saw the new menu entry, it did the same stuff.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/doc/README.kiosk <span style="color: grey">(b95002d)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(b439e04)</span></li>
<li>kdeui/actions/kstandardaction.h <span style="color: grey">(3064301)</span></li>
<li>kdeui/actions/kstandardaction.cpp <span style="color: grey">(7de0c6f)</span></li>
<li>kdeui/actions/kstandardaction_p.h <span style="color: grey">(b8f8df1)</span></li>
<li>kdeui/dialogs/jointhegame.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/dialogs/kaboutkdedialog_p.cpp <span style="color: grey">(b9728bf)</span></li>
<li>kdeui/dialogs/kjointhegamedialog_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/dialogs/kjointhegamedialog_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/shortcuts/kstandardshortcut.h <span style="color: grey">(b31e45c)</span></li>
<li>kdeui/shortcuts/kstandardshortcut.cpp <span style="color: grey">(669f750)</span></li>
<li>kdeui/widgets/khelpmenu.h <span style="color: grey">(3389068)</span></li>
<li>kdeui/widgets/khelpmenu.cpp <span style="color: grey">(f547c46)</span></li>
<li>kdeui/xmlgui/ui_standards.rc <span style="color: grey">(a0f5bed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110367/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>