<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109245/">http://git.reviewboard.kde.org/r/109245/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please commit. remember to add the kdepimlibs 4.10 requirement in the CMakeLists.txt though</pre>
<br />
<p>- Allen</p>
<br />
<p>On March 2nd, 2013, 2:12 p.m. UTC, Sergio Luis Martins wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and John Layt.</div>
<div>By Sergio Luis Martins.</div>
<p style="color: grey;"><i>Updated March 2, 2013, 2:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kde-workspace had a few classes that were duplicated in kdepim.
In 4.10 they were moved from kdepim to kdepimlibs, so now kde-workspace can use that instead of duplicating.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used "plasmoidviewer calendar" to test.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/calendar/CMakeLists.txt <span style="color: grey">(5539f99)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/README.txt <span style="color: grey">(dc1d36c)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/blockalarmsattribute.h <span style="color: grey">(71c8284)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/blockalarmsattribute.cpp <span style="color: grey">(28dff0c)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/calendar.h <span style="color: grey">(364fc81)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/calendar.cpp <span style="color: grey">(8ff81ef)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/calendar_p.h <span style="color: grey">(f9b92de)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/calendarmodel.h <span style="color: grey">(1acbfdd)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/calendarmodel.cpp <span style="color: grey">(251a615)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/calfilterproxymodel.h <span style="color: grey">(fe62155)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/calfilterproxymodel.cpp <span style="color: grey">(1820084)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/collectionselection.h <span style="color: grey">(4447afb)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/collectionselection.cpp <span style="color: grey">(41e03da)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/utils.h <span style="color: grey">(d923594)</span></li>
<li>plasma/generic/dataengines/calendar/akonadi/utils.cpp <span style="color: grey">(895edf9)</span></li>
<li>plasma/generic/dataengines/calendar/calendarengine.h <span style="color: grey">(18ae774)</span></li>
<li>plasma/generic/dataengines/calendar/calendarengine.cpp <span style="color: grey">(7235f74)</span></li>
<li>plasma/generic/dataengines/calendar/eventdatacontainer.h <span style="color: grey">(b170a14)</span></li>
<li>plasma/generic/dataengines/calendar/eventdatacontainer.cpp <span style="color: grey">(63db4df)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109245/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>