<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110390/">http://git.reviewboard.kde.org/r/110390/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks ok to me, but I can't test since I don't have pulse installed. (and I'm not at home)
Perhaps Colin (coling) or Harald (apachelogger) could look into it.
Anyway, I don't see anything that can be wrong :)</pre>
<br />
<p>- Casian</p>
<br />
<p>On May 11th, 2013, 8:05 p.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and Casian Andrei.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated May 11, 2013, 8:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes a problem in Phonon KCM which is always set as changed when using PulseAudio. Previous solution emits ready() signal when some parts of AudioSetup are not initialized yet. And changed() signal is connected to soon so that's the reason why this KCM is always set as changed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>phonon/kcm/audiosetup.cpp <span style="color: grey">(35dc4ca)</span></li>
<li>phonon/kcm/main.cpp <span style="color: grey">(5d75cba)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110390/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>