<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110315/">http://git.reviewboard.kde.org/r/110315/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 5th, 2013, 10:09 a.m. UTC, <b>Oswald Buddenhagen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">useradd also exists on debian ("useradd is a low level utility for adding users. On Debian, administrators should usually use adduser(8) instead."), so in principle the paths can be unified.
however, when i was trying to implement this a decade or so ago, useradd was apparently requiring the caller to provide a UID, at which point i simply gave up. did i look wrong? or is this feature a semi-new addition?</pre>
</blockquote>
<p>On May 5th, 2013, 10:29 a.m. UTC, <b>Raymond Wooninck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to the useradd man-page on openSUSE:
-r, --system
Create a system account.
System users will be created with no aging information in /etc/shadow, and their numeric identifiers are chosen in the
SYS_UID_MIN-SYS_UID_MAX range, defined in /etc/login.defs, instead of UID_MIN-UID_MAX (and their GID counterparts for the creation of
groups).
-u, --uid UID
The numerical value of the user's ID. This value must be unique, unless the -o option is used. The value must be non-negative. The
default is to use the smallest ID value greater than or equal to UID_MIN and greater than every other user.
So if UID is not given, then it will be determined through the default (as indicated).
I am also not sure if debian and openSUSE have the same version of useradd, so that the two could be merged in a single statement. If you are running debian, then please send me the man page for useradd and I will update the patch with a unified approach. </pre>
</blockquote>
<p>On May 5th, 2013, 10:37 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">O.o?
I've *never* explicitly added a UID to useradd - and yes, i'm that old ;-)
As a "reference", a p-l article from 1999
http://www.pro-linux.de/artikel/2/893/useradd.html
and here's a manpage, mentioning 1995 as last edition date
http://static.cray-cyber.org/Documentation/NEC_SX_R10_1/G1AH03E/USERADD.1M.HTML</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Further checking indicates that openSUSE is currently using shadow-4.1.5.1, which seems to come from debian as that the source tarball is
http://pkg-shadow.alioth.debian.org/releases/shadow-%{version}.tar.bz2
openSUSE added only a few patches to run a script to update a NIS database, so based on this I assume we can unified the coding. I will create a new patch in the next hour.</pre>
<br />
<p>- Raymond</p>
<br />
<p>On May 5th, 2013, 8:04 a.m. UTC, Raymond Wooninck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.</div>
<div>By Raymond Wooninck.</div>
<p style="color: grey;"><i>Updated May 5, 2013, 8:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch allows for the recognition of an openSUSE/SUSE installation and utilizes the correct tools to create the kdm user and group. This would fix an very old situation where at this moment only debian installations were recognized and properly handled.
The code follows the coding for debian</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing has been done on a couple of openSUSE systems and here the user and group were properly created and no more error messages were shown. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdm/kfrontend/genkdmconf.c <span style="color: grey">(69b42f1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110315/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>