<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110083/">http://git.reviewboard.kde.org/r/110083/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 2nd, 2013, 8:49 a.m. UTC, <b>Christophe Giboudeaux</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110083/diff/4/?file=141385#file141385line24" style="color: black; font-weight: bold; text-decoration: underline;">LibKFbAPI-KDEPIMConfig.cmake.in</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> include(${_currentDir}/LibKFbAPITargetsWithPrefix.cmake)</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CMake will stop at this point.
Exported targets can only be loaded once.
LibKFbAPITargetsWithPrefix.cmake is already loaded by LibKFbAPIConfig.cmake
One solution is to change this line: install(TARGETS kfbapi kfbapikdepim EXPORT kfbapiLibraryTargets ${INSTALL_TARGETS_DEFAULT_ARGS}) to use a different export name for kfbapikdepim (and then install a different export file for this library) but then you also have to require a different CMake version (multiple export-sets in a given project is a 2.8.10 feature iirc)
</pre>
</blockquote>
<p>On May 2nd, 2013, 9:13 a.m. UTC, <b>Christophe Giboudeaux</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hm, forget this, I wasn't fully awake and sent the wrong comment.
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, thanks for looking anyway!</pre>
<br />
<p>- Martin</p>
<br />
<p>On April 29th, 2013, 11:18 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and KDEPIM-Libraries.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated April 29, 2013, 11:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdepim-libs are needed in the facebook library only to return user info as KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This patch makes dependency on kdepim-libs optional and disables building the event classes completely in case kdepim-libs was not found.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds correctly here in both cases</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5aefdcf)</span></li>
<li>LibKFbAPI-KDEPIM.pc.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>LibKFbAPI-KDEPIMConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>LibKFbAPI.pc.in <span style="color: grey">(af537d1)</span></li>
<li>libkfbapi/CMakeLists.txt <span style="color: grey">(dac62bc)</span></li>
<li>libkfbapi/commentinfo.h <span style="color: grey">(e5578c7)</span></li>
<li>libkfbapi/kdepim-utils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkfbapi/kdepim-utils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkfbapi/likeinfo.h <span style="color: grey">(e06052e)</span></li>
<li>libkfbapi/noteinfo.h <span style="color: grey">(2492db1)</span></li>
<li>libkfbapi/noteinfo.cpp <span style="color: grey">(154593d)</span></li>
<li>libkfbapi/notificationinfo.h <span style="color: grey">(a882694)</span></li>
<li>libkfbapi/userinfo.h <span style="color: grey">(ac22a7e)</span></li>
<li>libkfbapi/userinfo.cpp <span style="color: grey">(26c64da)</span></li>
<li>libkfbapi/userinfoparser_p.h <span style="color: grey">(0189a17)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110083/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>