<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109841/">http://git.reviewboard.kde.org/r/109841/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 7d99e02d91080b7335abd7f853fee7e29a99bd26 by Maarten De Meyer to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 22nd, 2013, 7:10 p.m. UTC, Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated April 22, 2013, 7:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use encrypted https for the web shortcuts that support it. Make sure the site does not redirect to unencrypted connection. (exception: google feeling lucky)
Other shortcuts need more changes to support SSL. A lot are outdated, I'll post a patch for them soonish.
This small change should improve protection against networks sniffers.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All shortcuts use https and have a valid ssl certificate.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=308029">308029</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kurifilter-plugins/ikws/searchproviders/blip.desktop <span style="color: grey">(b308ad3)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/bugft.desktop <span style="color: grey">(f7aeff7)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/duckduckgo.desktop <span style="color: grey">(0ac02ed)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/duckduckgo_info.desktop <span style="color: grey">(69dbabb)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/duckduckgo_shopping.desktop <span style="color: grey">(538945f)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/facebook.desktop <span style="color: grey">(1ab6de1)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/flickrcc.desktop <span style="color: grey">(8ab0044)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/github.desktop <span style="color: grey">(5af6fe6)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/gitorious.desktop <span style="color: grey">(2a801d9)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google.desktop <span style="color: grey">(86fc2e3)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_advanced.desktop <span style="color: grey">(e3073b9)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_code.desktop <span style="color: grey">(3a6f94f)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_groups.desktop <span style="color: grey">(0aa3e7e)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_lucky.desktop <span style="color: grey">(8b9837f)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_maps.desktop <span style="color: grey">(2beef40)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_news.desktop <span style="color: grey">(beccf05)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/identica_groups.desktop <span style="color: grey">(c978be9)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/identica_notices.desktop <span style="color: grey">(6c723d4)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/identica_people.desktop <span style="color: grey">(41b0064)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/kde_forums.desktop <span style="color: grey">(e7acaaa)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/wikipedia.desktop <span style="color: grey">(02a3241)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/wiktionary.desktop <span style="color: grey">(1655241)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/wolfram_alpha.desktop <span style="color: grey">(6a8bda6)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/youtube.desktop <span style="color: grey">(0549216)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109841/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>