<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110057/">http://git.reviewboard.kde.org/r/110057/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 16th, 2013, 9:35 p.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for spotting this. If this does not exceed your C++ skills, could you try creating the objects on the stack instead, so they are automatically deleted once out of scope?</pre>
</blockquote>
<p>On April 17th, 2013, 1:11 p.m. UTC, <b>Dario Cambié</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I've tried without success :(</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's wrong anyway, see Alberts comment.
Depending on the pointer use, you'll either have to just delete complex in the UnitPrivate (and ensure to init it as NULL) or use some shared data pointer (and delete it with the last unref)
Whether from a stack or heap object, the U macro will create data on the heap, linking pointer or reference which will dangle around when you delete it or drop out of context.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On April 16th, 2013, 9:31 p.m. UTC, Dario Cambié wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dario Cambié.</div>
<p style="color: grey;"><i>Updated April 16, 2013, 9:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Little patch for memory leaks in kunitconversion: functions dynamically created were never deleted.
Not sure if the patch is correct (C++ is not my language at all) but it seems to "work for me".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, no more mem leaks according to valgrind.
valgrind before (e.g.):
==8754== 8 bytes in 1 blocks are definitely lost in loss record 110 of 644
==8754== at 0x4C2AF8E: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==8754== by 0x5A3EE11: Angle::Angle() (angle.cpp:51)
valgrind after:
no such alert</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kunitconversion/angle.cpp <span style="color: grey">(6333925)</span></li>
<li>kunitconversion/fuel_efficiency.cpp <span style="color: grey">(1914fab)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110057/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/16/0001-Fix-minor-mem-leaks-in-kunitconversion-angle-and-fue.patch">0001-Fix-minor-mem-leaks-in-kunitconversion-angle-and-fue.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>