<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109923/">http://git.reviewboard.kde.org/r/109923/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, of course.
To unconfuse you: $Id$ was expanded by CVS and by svn to some information about the last commit to the file. This is why you see
($Id: kded.cpp 1204125 2010-12-06 11:17:10Z dfaure $) -- it means that the version of kded.cpp compiled into that binary was the one at svn revision 1204125, which was a commit by myself on Dec 6, 2010.
With the move to Git, $Id$ should obviously be removed everywhere.</pre>
<br />
<p>- David</p>
<br />
<p>On April 9th, 2013, 2:08 p.m. UTC, Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated April 9, 2013, 2:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This can be seen as follow up of http://git.reviewboard.kde.org/r/109906. So I will not say too much here, since the main points in that review for plasma-desktop and krunner also apply to kded:
1. uses a dead (and mysterious) version, which provides no useful information in practice
2. receives quite a lot of crash reports, especially those from outdated KDE installations .
That "$Id$" version used by kded, which has been in use for more than 10 years, is really mysterious. Is it intended to provide some magic ? The git history doesn't tell me much.
On the other hand, searching for kded crashes on bugzilla gives me a list of version variants:
kded4 ($Id$) // note, this is the most common one)
kded4 ($Id: kded.cpp 1031637 2009-10-05 16:58:19Z lunakl $)
kded4 ($Id: kded.cpp 1107474 2010-03-25 19:04:25Z aseigo $)
kded4 ($Id: kded.cpp 1128583 2010-05-19 17:42:25Z aseigo $)
kded4 ($Id: kded.cpp 1149056 2010-07-12 13:39:10Z aholzammer $)
kded4 ($Id: kded.cpp 1151015 2010-07-17 13:50:01Z pokrzywka $)
kded4 ($Id: kded.cpp 1156841 2010-07-29 19:59:05Z zander $)
kded4 ($Id: kded.cpp 1192875 2010-11-04 08:22:15Z ervin $)
kded4 ($Id: kded.cpp 1204125 2010-12-06 11:17:10Z dfaure $)
, which makes it only more confusing to me.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kded/kded.cpp <span style="color: grey">(0d7b961)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109923/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>